-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cherry-Pick][e2e] Add test cases for pre-created VPC (#933) #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to add a new end-to-end test for the pre-created VPC, it includes these steps, 1. Create a VPC/LBS/Attachment on NSX 2. Create a Namespace on vCenter or K8s, which depends on if the setup is a wcp testbed or not. Note, it planned to run the test on wcp testbed, please provide a valid pair of vc-user and vc-password which has the permission to create instance on vCenter 3. Create LoadBalancer typed Service inside the Namespace 4. Create server Pod for the LoadBalancer typed Service 5. Create client Pod in the same Namespace 6. Verified the traffic from the client Pod to the LoadBalancer's external IP 7. Delete LoadBalancer typed Service and verified that the realted NSX resources are removed as expected 8. Delete the Namespace from vCenter or K8s 9. Delete the VPC from NSX
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.2.0 #970 +/- ##
=======================================
Coverage 74.04% 74.04%
=======================================
Files 118 118
Lines 16393 16393
=======================================
Hits 12139 12139
Misses 3473 3473
Partials 781 781
|
/e2e |
2 similar comments
/e2e |
/e2e |
wenqiq
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
zhengxiexie
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to add a new end-to-end test for the pre-created VPC, it includes these steps,