Add AllowOverwrite for some clients #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoZou1
force-pushed
the
v42allowoverwrite
branch
from
a6f5396 to
b5db7c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.2.0 #941 +/- ##
==========================================
+ Coverage 74.06% 74.11% +0.04%
==========================================
Files 119 118 -1
Lines 16430 16413 -17
==========================================
- Hits 12169 12164 -5
+ Misses 3477 3467 -10
+ Partials 784 782 -2
|
|
/e2e |
6 similar comments
|
/e2e |
|
/e2e |
|
/e2e |
|
/e2e |
|
/e2e |
|
/e2e |
timdengyun
approved these changes
Dec 13, 2024
dantingl
approved these changes
Dec 13, 2024
Some clients may operate resources created by other PI so 'X-Allow-Overwrite' should be True. Add the header for those clients. Remove headerconfig.go since it's only used for deprecated rest connector Test Done: 1. use user=admin to run cleanup 2. check if subnetport has been deleted which created by WCP user
TaoZou1
force-pushed
the
v42allowoverwrite
branch
from
b5db7c1 to
ad6fa16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients may operate resources created by other PI so 'X-Allow-Overwrite' should be True. Add the header for those clients.
Remove headerconfig.go since it's only used for deprecated rest connector
Test Done: