-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Add test cases for pre-created VPC #933
Conversation
f4efb12
to
b818bc0
Compare
/e2e |
b818bc0
to
336b301
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage 73.37% 73.37%
=======================================
Files 118 118
Lines 16394 16394
=======================================
Hits 12029 12029
Misses 3581 3581
Partials 784 784
|
/e2e |
1 similar comment
/e2e |
336b301
to
e55f61d
Compare
/e2e |
509290d
to
7b88c8a
Compare
7b88c8a
to
c6cc042
Compare
/e2e |
1 similar comment
/e2e |
db80623
to
994ada6
Compare
/e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/e2e |
1 similar comment
/e2e |
994ada6
to
93f8915
Compare
/e2e |
2 similar comments
/e2e |
/e2e |
93f8915
to
c6cca51
Compare
/e2e |
c6cca51
to
18ad4b0
Compare
This change is to add a new end-to-end test for the pre-created VPC, it includes these steps, 1. Create a VPC/LBS/Attachment on NSX 2. Create a Namespace on vCenter or K8s, which depends on if the setup is a wcp testbed or not. Note, it planned to run the test on wcp testbed, please provide a valid pair of vc-user and vc-password which has the permission to create instance on vCenter 3. Create LoadBalancer typed Service inside the Namespace 4. Create server Pod for the LoadBalancer typed Service 5. Create client Pod in the same Namespace 6. Verified the traffic from the client Pod to the LoadBalancer's external IP 7. Delete LoadBalancer typed Service and verified that the realted NSX resources are removed as expected 8. Delete the Namespace from vCenter or K8s 9. Delete the VPC from NSX
18ad4b0
to
f9ba87d
Compare
/e2e |
1 similar comment
/e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Just a nit comment.
This change is to add a new end-to-end test for the pre-created VPC, it includes these steps, 1. Create a VPC/LBS/Attachment on NSX 2. Create a Namespace on vCenter or K8s, which depends on if the setup is a wcp testbed or not. Note, it planned to run the test on wcp testbed, please provide a valid pair of vc-user and vc-password which has the permission to create instance on vCenter 3. Create LoadBalancer typed Service inside the Namespace 4. Create server Pod for the LoadBalancer typed Service 5. Create client Pod in the same Namespace 6. Verified the traffic from the client Pod to the LoadBalancer's external IP 7. Delete LoadBalancer typed Service and verified that the realted NSX resources are removed as expected 8. Delete the Namespace from vCenter or K8s 9. Delete the VPC from NSX
This change is to add a new end-to-end test for the pre-created VPC, it includes these steps, 1. Create a VPC/LBS/Attachment on NSX 2. Create a Namespace on vCenter or K8s, which depends on if the setup is a wcp testbed or not. Note, it planned to run the test on wcp testbed, please provide a valid pair of vc-user and vc-password which has the permission to create instance on vCenter 3. Create LoadBalancer typed Service inside the Namespace 4. Create server Pod for the LoadBalancer typed Service 5. Create client Pod in the same Namespace 6. Verified the traffic from the client Pod to the LoadBalancer's external IP 7. Delete LoadBalancer typed Service and verified that the realted NSX resources are removed as expected 8. Delete the Namespace from vCenter or K8s 9. Delete the VPC from NSX
This change is to add a new end-to-end test for the pre-created VPC, it includes these steps,