-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update NetworkConfiguration CR #623
Conversation
abf2b3b
to
e54d5ac
Compare
99bdeda
to
eb66a4b
Compare
/e2e |
6f568f6
to
225e5f5
Compare
0fe9fb3
to
3028d3b
Compare
BTW, could you check why e2e test not pass? |
As this PR uses the new VPC API and the e2e testbed uses the old NSX version, I think it’s expected that the related test cases would fail. |
@lxiaopei pls help confirm some of the comments. |
/e2e |
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
f3bef41
to
f4c401d
Compare
4c24291
to
e75e348
Compare
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
/e2e |
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to go through all the codes which have ExternalIPv4Blocks and other removed parameter, to see if anything else is missing
297c3e8
to
77cacc1
Compare
4855c5e
to
dd55c2c
Compare
e8f54f4
to
627f075
Compare
Signed-off-by: Wenqi Qiu <[email protected]>
Signed-off-by: Wenqi Qiu <[email protected]>
627f075
to
ff5d03b
Compare
* Update NetworkConfiguration CR with new VPC API --------- Signed-off-by: Wenqi Qiu <[email protected]>
Create VPC with new VPC API model
Create a Project
wenqi-test
in NSX UICreate a namespace