-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform specific fields in BYOHost CRD #479
Platform specific fields in BYOHost CRD #479
Conversation
Signed-off-by: Sachin Kumar Singh <[email protected]>
Signed-off-by: Sachin Kumar Singh <[email protected]>
Just curious, why host |
@mayur-tolexo according to kubebuilder docs, |
@sachinkumarsingh092, thanks for clarifying. Ya make sense to provide only status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
We need platform-specific info regarding the host in BYOHost CRDs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #469
Additional information
Changes in brief:
HostStatus
which has all the platformspecific details like OS name, Kernel version, architecture etc. We introduce a new field inByoHostStatus
with this type.make generate
, we let controller-gen introduce these new fields in the CRDs automatically.HostStatus
.Special notes for your reviewer