-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer e2e test #255
base: main
Are you sure you want to change the base?
Installer e2e test #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ratanasovvmw - This e2e test seems to test the installer in isolation - so its not really an e2e test then :)
I think this should be integrated within our existing e2e suite. More specifically, when we run the PR-Blocking test, the installer should be triggered as part of that workflow.
So what that means is
- That test would need to build the bundle and host it (So these bash lines move into the golang test itself - probably e2e_suite_test.go)
- We would need to start Vagrant in our e2e_suite_test.go
- The e2e tests should then spin up all containers inside this Vagrant VM. So that would mean modifying the e2e_docker_helper.go to do this.
- We would then stop invoking
--skip-installation
- as we do here
That is a proper e2e test in my mind. Thoughts?
@jamiemonserrate To spin up a container in Vagrant (initially I was going to do so) you need containerd etc and configure it in the Vagrant VM. This is what installer is doing and we want to test. For example, if we remove the kernel configuration from installer, the test may still pass because it is already there. It is interesting to see if multiple BYOH hosts can co-exist on the same VM : installer is configuring the kernel which is shared for all containers and there could be races between install/uninstall installing different k8s versions etc. |
This test executes the following workflow:
Upon success return 0.