Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer cflinuxfs4 #26

Merged
merged 1 commit into from
May 16, 2023
Merged

Prefer cflinuxfs4 #26

merged 1 commit into from
May 16, 2023

Conversation

acrmp
Copy link
Contributor

@acrmp acrmp commented May 16, 2023

Description

  • The tile-generator will currently use cflinuxfs3 if it exists even if cflinuxfs4 is the default stack: Pushing applications with cflinuxfs4 cf-platform-eng/tile-generator#325
  • Redefine the get_stack function to prefer cflinuxfs4 if available.
  • Only use cflinuxfs4 if the go_buildpack is available. Some environments will have the cflinuxfs4 stack but no go_buildpack for cflinuxfs4.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

- The tile-generator will currently use cflinuxfs3 if it exists even if
  cflinuxfs4 is the default stack:
  cf-platform-eng/tile-generator#325
- Redefine the get_stack function to prefer cflinuxfs4 if available.
- Only use cflinuxfs4 if the go_buildpack is available. Some
  environments will have the cflinuxfs4 stack but no go_buildpack for
  cflinuxfs4.
Copy link
Member

@Benjamintf1 Benjamintf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks kinda hacky, but idk if that's helpful given what seems to be the state of the tile generator.

Have we tried making a pr to tile generator?

Anyways, otherwise lgtm.

@acrmp
Copy link
Contributor Author

acrmp commented May 16, 2023

Have we tried making a pr to tile generator?

@Benjamintf1 I created an issue on the tile-generator project (linked in the commit) to consider changing the default.
cf-platform-eng/tile-generator#325

@acrmp acrmp merged commit e74c69b into main May 16, 2023
@acrmp acrmp deleted the pr/prefer-cflinuxfs4 branch May 16, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants