This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
[WIP] Add script to create release on github #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
suggested changes
Jul 3, 2018
| @@ -0,0 +1,36 @@ | |||
| from github import Github | |||
There was a problem hiding this comment.
Is this from PyGithub? Let's document that as a requirement/dependency somewhere.
That import should probably be moved to a separate # Import 3rd party libs line too, just to keep things organized. I know that is picky, but might as well start off that way :)
| repo = Github(opts['GITHUB_TOKEN']).get_repo('saltstack/salt') | ||
|
|
||
| # create release | ||
| # todo: make sure the tag we are about to create a release for already exists |
There was a problem hiding this comment.
I know this is a first pass, but I'd like to see this kind of validation happen before this script is merged in.
There was a problem hiding this comment.
k i'll add the [WIP] for now until i can get to this again. might be a while.
Ch3LL
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have only tested this on my personal repo's. So will need to refine this script going forward and test it on salts repo.
Added in the script what still needs to be done.