Add recipe check vllm e2e #929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject/llm-compressor into sparseautomodel-removal-followup
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
rahul-tuli
previously approved these changes
Nov 21, 2024
Merged
horheynm
commented
Nov 25, 2024
| "config.json", | ||
| r"^model(?:-\d{5}-of-\d{5})?\.safetensors$", | ||
| "recipe.yaml", | ||
| "tokenizer.json", |
There was a problem hiding this comment.
any other default files suggestions welcome here
kylesayrs
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Blocked on #927
Add tests to make sure recipe is being saved on save_pretrained. Previously the session was reset, so not recipe to save.
Also added tests to check that major files are saved in the save_dir
TEST PLAN:
Test run