Allow Shortcutting Min-max Observer #887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
dsikka
approved these changes
Nov 21, 2024
dsikka
reviewed
Nov 22, 2024
| observer = Observer.load_from_registry( | ||
| observer, quantization_args=quantization_args | ||
| quantization_args.observer, quantization_args=quantization_args |
There was a problem hiding this comment.
I think we should be consistent in how we're fetching the observer - either use the get_observer method or remove it and do it how you're doing it here.
There was a problem hiding this comment.
Personally in favor of removing the get_observer now that observer refactor work is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
MovingAverageMinMaxObserver->MinMaxObserversince moving average is not required to use itself.averaging_constant == 1.0Testing
examples/quantization_w4a16/llama3_example.pyto completion