Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Sparse compression to save_compressed #821

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

rahul-tuli
Copy link
Collaborator

@rahul-tuli rahul-tuli commented Oct 6, 2024

PR Description: Before this PR, sparse compression was not being utilized since it was explicitly set to False in the codebase. This PR enables sparse compression, allowing us to take advantage of its benefits for reduced memory on disk

Copy link

github-actions bot commented Oct 6, 2024

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this as well, it seems to be a bug since this branch is interested in the case in which sparsity config should be inferred

Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per offline discussion, we will allow this automatic behavior

@dsikka dsikka merged commit 72b098e into main Oct 8, 2024
5 of 6 checks passed
@dsikka dsikka deleted the set-sparse-compression-true branch October 8, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants