Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows/actions #774

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

dbarbuzzi
Copy link
Collaborator

@dbarbuzzi dbarbuzzi commented Oct 3, 2024

SUMMARY:
These changes perform some cleanup in the existing workflows in advance of looking at adding GPU support:

  • The actions/checkout, actions/setup-python, and actions/github-script usages have been updated to the latest version
  • The use of the deprecated set-output has been replaced with the current standard
  • Some redundancies have been cleaned up

The first two points will reduce a lot of noise in the runs as there were messages for each usage of the outdated actions due to their age/using outdated Node.js (internally to the actions).

The final point is a general cleanup to keep things simple.

TEST PLAN:
The runs for this PR should have the expected outcomes, but without the various warnings/etc. about the outdated actions.

@dbarbuzzi dbarbuzzi changed the title Update-workflow-actions Update workflows/actions Oct 3, 2024
@mgoin mgoin merged commit e051dad into vllm-project:main Oct 7, 2024
5 of 6 checks passed
@dbarbuzzi dbarbuzzi deleted the update-workflow-actions branch October 7, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants