Frontend

[itsdonnix]

Base on https://github.com/vlingo/vlingo-schemata/tree/master/src/main/frontend

You guys can view it on vercel:

• vlingo-auth-ui-donnisnoni.vercel.app
• vlingo-auth-ui-git-frontend-donnisnoni.vercel.app
• vlingo-auth-ui.vercel.app
• vlingo-auth-ui.donnisnoni.vercel.app
• vlingo-auth-ui-git-frontend.donnisnoni.vercel.app

[VaughnVernon]

@donnisnoni Thanks! I have requested @Florian-Schoenherr to review your work.

Florian: please review if possible. @donnisnoni is a recent graduate and asked for an opportunity to learn Svelte and Sappier, so I gave him vlingo-auth UI to implement. If you can't review please reassign to Abdullah (it's just that he has other piorities). Thanks.

[itsdonnix]

Please guide me @Florian-Schoenherr

[Florian-Schoenherr]

Hi @donnisnoni!
You didn't have to copy over utils or stores from schemata, haha.
Your sign-off is missing (relevant to DCO), you're using vscode so there are settings for that:

Editorconfig/Prettier/eslint is a great addition, honestly would've used it myself if I understood better what/when these format stuff.

Regarding Svelte and Sapper, the Docs/Tutorial on their sites are pretty great and for some more specific questions there's also a Svelte Discord Server. Oh and I see you've build a little project with it before, so maybe only Sapper is new to you?

Smelte is not that good, SMUI is not maintained - we use svelte-materialify.

[Florian-Schoenherr]

@VaughnVernon in #5 there was some UI implemented, if @donnisnoni knows Vue/Vuetify he can take a look there, too, for some of the structure?

[VaughnVernon]

@Florian-Schoenherr yes I noted there is an existing UI and mockups in docs for @donnisnoni to use.

@abdullahcalisir12 said that the current UI code looked like an exact copy from schemata with no changes to reflect auth language and use cases. Of course that won't work 😃

[itsdonnix]

Thank's @Florian-Schoenherr!

Yes, I never learn sapper before 😁 .

I've used vue & vuetify before. BTW, I use them in my thesis. I will take a look on #5.

[itsdonnix]

You didn't have to copy over utils or stores from schemata, haha.

Hahaha.. I just try to read the code and hope that I can understand how it works... 😀

[itsdonnix]

You guys can view the #5 version on http://tightfisted-sock.surge.sh/

[itsdonnix]

Sorry,, the signing key is still using my old account 😁

[Florian-Schoenherr]

You guys can view the #5 version on http://tightfisted-sock.surge.sh/

That's the old version? That's pretty nice.
It uses a Datatable, which materialify doesn't have right now. I would either suggest building your own with materialify components or, probably easier for now, using a standalone svelte "table" or "datatable" component, until materialify has one.

[itsdonnix]

It uses a Datatable, which materialify doesn't have right now.

Yeah... Unfortunately , I think of it from yesterday... Like ohhh,,, need more work 😁

I would either suggest building your own with materialify components or, probably easier for now, using a standalone svelte "table" or "datatable" component, until materialify has one.

OMG,, it will take times if i must create one, I would try to find existing svelte datatable lib instead 😃

[itsdonnix]

That's the old version? That's pretty nice.

@Florian-Schoenherr Agree!! Therefore, I thought yesterday, "This is so good, why don't I continue working on it?"

But I'm thinking of getting some experience with svelte and sapper (although svelte-kit will replace that)

BTW, If you have feedback, please let me know 😄.

[itsdonnix]

Take a look guys... 👀 @VaughnVernon @Florian-Schoenherr

[Florian-Schoenherr]

All the copied schemata files make it really hard to review.
I have looked at the code, nice idea with the Vercel Preview, don't know if we need it but if you could put the "preview link" somewhere here, it would be nice for reviewing Design :)

Regarding schemata code: not much of it is reusable, I would suggest looking at xoom-starter code instead (not the AggregateDialog, but the normal forms). I just realized I never wrapped my forms in <form>, which I should've.

[itsdonnix]

Guys.. really... I dont understand the wireframes... i think I will just design the UI without care about the interaction since it so hard to understand

[VaughnVernon]

@Florian-Schoenherr The other day @donnisnoni informed me that he thinks this UI has been completed. Would it be possible for you to review this in the next few days and see what you think? I needs to be tested with the server using HTTP requests. I am not sure how much of that's already been accomplished but given your experience with the other tool UIs this should be straightforward for you. Thanks!

[itsdonnix]

Thanks @VaughnVernon ! I just remember that assign members/group role feature is not finished yet

[VaughnVernon]

@donnisnoni What is the completion date for this?

[itsdonnix]

@VaughnVernon Can I completed my work here?