Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use build version aware caching #57

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Mar 23, 2024

The changes add a version-aware cache. This fixes the issue where an old cache would prevent updates and bug fixes from becoming visible to users.

obsolete The versioning follows the same scheme as we do for the metadata/stubs. But instead of using a hardcoded version for the metadata(which is handled separately and changes less often) the changes in the PR add a more dynamic handling for the analyzer's indexing cache based on the build commit. This should be appropriate as it is affected by most commits to the project.

Refs to stubs versioning:

@ttytm ttytm changed the title feat: use v-analyzer version aware caching feat: use build version aware caching Mar 23, 2024
@ttytm

This comment was marked as outdated.

@ttytm ttytm marked this pull request as draft March 24, 2024 10:52
@ttytm ttytm marked this pull request as ready for review March 24, 2024 11:04
@ttytm ttytm marked this pull request as draft March 24, 2024 16:33
@ttytm ttytm force-pushed the feat/version-aware-cache branch from 08c6260 to 240c5ec Compare March 24, 2024 18:37
@ttytm ttytm marked this pull request as ready for review March 24, 2024 18:50
@ttytm ttytm force-pushed the feat/version-aware-cache branch 2 times, most recently from 40c498b to 532f383 Compare March 25, 2024 02:21
@spytheman spytheman merged commit 52f4541 into vlang:main Mar 25, 2024
12 checks passed
@ttytm ttytm deleted the feat/version-aware-cache branch March 25, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants