fix: incorrect initialization #146
Conversation
Fixed incorrect deserialization of some field according to the latest Language Server Protocol specification.
|
related issue: |
|
oh i read V's source code and find any occurance of 'skip' will cause the field skipped, no matter if field's json name is specified or not. gonna fix it soon (by implementing |
|
find a even more serious problem (in the V source code)... the json decoder codegen doesn't handle optional sum type correctly |
But because of some problem within the V's json decode generator it's not possible to handle it prefectly with V's json module yet (optional type not handled correctly for sumtype & other types except struct) fomat
|
I think those fields are not used by |
| @@ -9,7 +9,7 @@ pub mut: | |||
| pub struct CompletionItemSettings { | |||
| snippet_support bool @[json: snippetSupport] | |||
| commit_characters_support bool @[json: commitCharactersSupport] | |||
| documentation_format bool @[json: documentationFormat] | |||
| documentation_format []string @[json: documentationFormat] | |||
There was a problem hiding this comment.
It is not used for anything.
Imho just delete documentation_format.
| root_uri DocumentUri @[json: rootUri] | ||
| root_path DocumentUri @[json: rootPath] | ||
| // TODO: Change this to `?LSPAny` once V fixed its JSON decoder codegen. (or shall we use json2?) | ||
| initialization_options LSPAny @[json: initializationOptions] |
There was a problem hiding this comment.
It is not used for anything, imho just delete initialization_options.
There was a problem hiding this comment.
Well they ARE used somewhere...
(I tried to change the type of this field without modifying anything and the compiler complains about the type, obviously some part of the code used that)
it IS ok to delete documentation_format though. but deleting initialization_options seems to be way harder than documentation_format.
| ls.initialization_options = params.initialization_options.fields() | ||
| options := params.initialization_options | ||
| if options is string { | ||
| ls.initialization_options = options.fields() | ||
| } |
There was a problem hiding this comment.
This will not be needed, if the fields are deleted.
Fixed incorrect deserialization of some field according to the latest Language Server Protocol specification.
According to the definition of
InitializeParams, the fieldinitializationOptionswith any type should not be an error while deserializing. In CoC.nvim, this field is marked as "deprecated". After checking more implementations,{},""andnullshould be acceptable for clients that doesn't use this field to send, but sending{}(from CoC.nvim) causedv-analyzerto crash.According to the definition of
CompletionClientCapabilities, the type ofdocumentationFormatshould beMarkupKind[]?(whereMarkupKindis just"markdown" | "plaintext", according to the definition), but somehow we are deserializing this thing asbool. This also causedv-analyzerto crash.