analyzer: update pascal_case_to_snake_case util function
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, I did not saw that; I've already commited 2584e86 . |
spytheman
reviewed
Jun 14, 2024
Comment on lines
3
to
16
| pub fn pascal_case_to_snake_case(s string) string { | ||
| mut res := '' | ||
| for index, c in s { | ||
| if c.ascii_str().is_upper() { | ||
| if index > 0 { | ||
| res += '_' | ||
| } | ||
| res += c.ascii_str().to_lower() | ||
| } else { | ||
| res += c.ascii_str() | ||
| if s == '' { | ||
| return '' | ||
| } | ||
| mut res := s[0].ascii_str().to_lower() | ||
| for i in 1 .. s.len { | ||
| c := s[i] | ||
| if (c != `_` && s[i - 1] != `_`) && (c.ascii_str().is_upper() || c.is_digit()) { | ||
| res += '_' | ||
| } | ||
| res += c.ascii_str().to_lower() | ||
| } | ||
| return res | ||
| } |
There was a problem hiding this comment.
That seems more complex than before; is there a particular problem that it solves, beside the one revealed in the other PR?
|
No problem. Maybe it can be put on top, as the simpler fix would fail with the added test. |
spytheman
reviewed
Jun 14, 2024
| @@ -5,6 +5,7 @@ fn test_pascal_case_to_snake_case() { | |||
| assert pascal_case_to_snake_case('SomeValue') == 'some_value' | |||
| assert pascal_case_to_snake_case('SomeValue') == 'some_value' | |||
| assert pascal_case_to_snake_case('SomeValue1') == 'some_value_1' | |||
| assert pascal_case_to_snake_case('some_value_1') == 'some_value_1' | |||
There was a problem hiding this comment.
some_value_1 is not a pascal case input 🤔
There was a problem hiding this comment.
Right. It just makes sure it's not corrupted.
E.g. the current would turn it to
some__value___1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.