feat: update title on note content change #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixalien
reviewed
Oct 23, 2024
There was a problem hiding this comment.
A better approach would be to add another property named title to the Note (it's in util.ts).
Then you can easily bind the note's title to the note's content, by doing something similar to this in the constructor of the Note:
this.bind_property_full("title", this, "content", flags, (_, content) => {
// return the first n-chars of the content, or the first line
}, null);Then you can create yet another binding from the note's title to the note window's title
vixalien
reviewed
Oct 23, 2024
vixalien
reviewed
Oct 23, 2024
vixalien
reviewed
Oct 23, 2024
vixalien
reviewed
Oct 24, 2024
src/window.ts
Outdated
| GObject.BindingFlags.SYNC_CREATE, | ||
| (_, title) => { | ||
| if (!title) { | ||
| return [true, "Untitled Note"]; |
There was a problem hiding this comment.
I feel like "Sticky Note" may be better here.
Also, wrap the string in a _("string") so that it may get picked up by gettext (the translation infrastructure).
Suggested change
| return [true, "Untitled Note"]; | |
| return [true, _("Sticky Note")]; |
|
Thank you! I still need to test this locally, but looks good |
vixalien
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that you could get one note from dock by title directly