Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct emit_time for the global_time_precision #238

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

eagmon
Copy link
Member

@eagmon eagmon commented Feb 21, 2024

Thanks to @pmendes for reporting this bug to me. The emit_time was showing some floating point rounding errors, which were not corrected by global_time_precision. This fix checks for global_time_precision and corrects the emit_time accordingly


By creating this pull request, I agree to the Contributor License
Agreement, which is available in CLA.md at the top level of this
repository.

@eagmon eagmon requested a review from a team as a code owner February 21, 2024 15:52
@eagmon eagmon merged commit 2157be8 into master Feb 21, 2024
12 checks passed
@eagmon eagmon deleted the emit-time-precision branch February 21, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant