Process keywords #177
Closed
Process keywords #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivarium/processes/growth_rate.py
Outdated
Comment on lines
36
to
40
| **base_parameters): | ||
|
|
||
| parameters = locals().copy() | ||
| base_parameters = parameters.pop('base_parameters') | ||
| self.initialize(parameters, base_parameters) |
There was a problem hiding this comment.
I know I helped create this thing, but on reflection I feel the cost here for Process creators to have to add this four-line litany to every __init__ method is too high. I appreciate what we're trying to solve here but the trade-off can't be to create cryptic things we demand of our users.... IMO
There was a problem hiding this comment.
Maybe we can make this optional? If people want function keywords, they can follow this template. But the previous __init__ approach with defaults and a parameters dict can work just as well.
| """ | ||
| _ = states | ||
| return self.parameters['time_step'] | ||
| return self.parameters['timestep'] |
There was a problem hiding this comment.
timestep change is good, maybe a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR includes work towards improved handling of Process parameters as keywords (#171)
By creating this pull request, I agree to the Contributor License
Agreement, which is available in
CLA.mdat the top level of thisrepository.