Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing schema so eslint would accept options #145

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix: add missing schema so eslint would accept options #145

merged 3 commits into from
Oct 25, 2024

Conversation

samtsai
Copy link
Contributor

@samtsai samtsai commented Oct 24, 2024

No description provided.

@samtsai samtsai mentioned this pull request Oct 24, 2024
Open
vitonsky
vitonsky reviewed Oct 25, 2024
View reviewed changes
Copy link
Owner

@vitonsky vitonsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patch.

Let's clarify about changes not related to schema definition, and will merge.

src/rules/alias.test.ts Show resolved Hide resolved
src/rules/alias.ts Show resolved Hide resolved
@vitonsky vitonsky merged commit 4e0ba69 into vitonsky:master Oct 25, 2024
4 checks passed
@samtsai samtsai deleted the add-schema-for-rule-options branch October 25, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitonsky vitonsky vitonsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samtsai @vitonsky