-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for save changes async for issue #1 #2
base: master
Are you sure you want to change the base?
Add support for save changes async for issue #1 #2
Conversation
This reverts commit b470bac.
I tried to rewrite it without the await keyword but that's not going to fly since the 4.0 version of EntityFramework doesn't actually have a SaveChangesAsync to overwrite. Therefore the current strategy of using the same HookedDbContext file and compiling it in two different projects fails for the 4.0 version. Possible solutions
My vote is still to drop support for old versions of .Net |
I'm up for dropping .NET 4 support at this point. EF6 for 4.5 is a different beast and should just be rewritten as a 4.5 assembly. For legacy support, users can keep using the current version for those using EF6 with .NET 4. I haven't had a chance to review your code, but I think we can probably do a bunch of cleanup since we won't have .NET 4 support anymore. |
Not sure what to do with EfHooks/EfHooks.Test (the non .Net 4.5 version). Since < 4.5 doesn't support the async keyword that project no longer compiles
Issue #1