test(jsdom): remove overrides (#306)

I have no idea why these were introduced as the only thing they seem to do is break unit tests. However my guess is that they compensated for missing features in older versions of jsdom and since they were implemented in jsdom itself it just malfunctions now. Co-authored-by: Yotam Berkowitz <[email protected]>
visjs · Feb 14, 2020 · 65364f4 · 65364f4
1 parent c1d4f4e
commit 65364f4
Showing 1 changed file with 0 additions and 118 deletions.
diff --git a/test/canvas-mock.js b/test/canvas-mock.js
@@ -6,120 +6,6 @@
 import jsdom from 'jsdom'
 import jsdom_global from 'jsdom-global'
 
-let canvasMock;  // Use one canvas instance for all calls to createElement('canvas');
-
-/**
- * This is a function.
- *
- * @param {element} el - An Element context to
- *
- * @example
- *
- *     foo('hello')
- */
-const replaceCanvasContext = (el) =>{
-  el.getContext = () => {
-    return {
-      fillRect: () => {},
-      clearRect: () => {},
-      getImageData: (x, y, w, h) => ({
-          data: new Array(w*h*4)
-      }),
-      putImageData: () => {},
-      createImageData: () => ([]),
-      setTransform: () => {},
-      drawImage: () => {},
-      save: () => {},
-      text: () => {},
-      fillText: () => {},
-      restore: () => {},
-      beginPath: () => {},
-      moveTo: () => {},
-      lineTo: () => {},
-      closePath: () => {},
-      stroke: () => {},
-      translate: () => {},
-      scale: () => {},
-      rotate: () => {},
-      circle: () => {},
-      arc: () => {},
-      fill: () => {},
-
-      //
-      // Following added for vis.js unit tests
-      //
-
-      measureText: (text) => ({
-          width: 12*text.length,
-          height: 14
-      })
-    };
-  }
-}
-
-
-/**
- * Overrides document.createElement(), in order to supply a custom canvas element.
- *
- * In the canvas element, getContext() is overridden in order to supply a simple 
- * mock object for the 2D context. For all other elements, the call functions unchanged.
- *
- * The override is only done if there is no 2D context already present.
- * This allows for normal running in a browser, and for node.js the usage of 'canvas'.
- *
- * @param {object} window - current global window object. This can possibly come from module 'jsdom',
- *                 when running under node.js.
- * @private
- */
-const overrideCreateElement = (window) => {
-  const d = window.document;
-  const f = window.document.createElement;
-
-  // Check if 2D context already present. That happens either when running in a browser,
-  // or this is node.js with 'canvas' installed. 
-  const ctx = d.createElement('canvas').getContext('2d');
-  if (ctx !== null && ctx !== undefined) {
-    //console.log('2D context is present, no need to override');
-    return;
-  }
-
-  window.document.createElement = (param) => {
-    if (param === 'canvas') {
-      if (canvasMock === undefined) {
-        canvasMock = f.call(d, 'canvas');
-        replaceCanvasContext(canvasMock);
-      }
-      return canvasMock;
-    } else {
-      return f.call(d, param);
-    }
-  };
-}
-
-/**
- * The override is only done if there is no 2D context already present.
- * This allows for normal running in a browser, and for node.js the usage of 'style'
- * property on a newly created svg element.
- *
- * @param {object} window - current global window object. This can possibly come from module 'jsdom',
- *                 when running under node.js.
- * @private
- */
-const overrideCreateElementNS = (window) => {
-  const d = window.document;
-  const f = window.document.createElementNS;
-
-  window.document.createElementNS = (namespaceURI, qualifiedName) => {
-    if (namespaceURI === 'http://www.w3.org/2000/svg') {
-      const result = f.call(d, namespaceURI, qualifiedName);
-      if (result.style == undefined) {
-        result.style = {};
-        return result;
-      }
-    }
-  };
-}
-
 /**
  * Initialize the mock, jsdom and jsdom_global for unit test usage.
  *
@@ -157,10 +43,6 @@ const mockify = (html = '') => {
     { skipWindowCheck: true, virtualConsole: virtualConsole}
   );
 
-  overrideCreateElement(window);   // The actual initialization of canvas-mock
-
-  overrideCreateElementNS(window);
-
   return cleanupFunction;
 }