Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quic go v0 27 #3

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Quic go v0 27 #3

merged 2 commits into from
Apr 21, 2022

Conversation

mfoxworthy
Copy link
Collaborator

Updated to QIC-GO v0.27
Added TCP_NODELAY to qpep client

Michael Foxworthy added 2 commits April 21, 2022 07:33
Revert "Updated to QUIC-GO v0.27"

This reverts commit d9239c3.
Revert "Update README.md"

This reverts commit c751c25.
@mfoxworthy
Copy link
Collaborator Author

Had a small snafu. I was in main when I committed and thought I had checked out mine. I had to revert a few things, but it should all be back to normal. Sorry about that.

@virtuallynathan
Copy link
Owner

All good! Thanks for reverting, I'll merge away.

Does this improve performance, per #1?

@virtuallynathan virtuallynathan merged commit 789d4bc into main Apr 21, 2022
@mfoxworthy
Copy link
Collaborator Author

mfoxworthy commented Apr 21, 2022

Well, I think it does, slightly. However, the CCA used in QUIC-GO didn't change. I think that'll be the area I'll work next. Instead of the 1-5Mbps I was seeing, I see 14Mbps. I think the main issue is that QUIC still needs to detect congestion. Even though it's UDP we still need to ACK with QUIC, so we can tune the ACK eliciting ratio and try to pump up the transmit window. That'll be the next test. However, I have a hunch we'll end up in the QUIC-GO source to change the CCA implementation. It's supposed to be pluggable like TCP as per RFC. I do notice a decrease in time to set up sessions. That is a plus. And, with 14Mbps browsing actually isn't too bad. DNS requests are also a big slow down. I think it would be good to push those into HTTP/3 at the proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants