[vioscsi] DriverEntry() improved tracing #1215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show the RegistryPath. Show the CrashDump Mode. Show StorPortInitialize() return value (including LONG). Show NTDDI_VERSION. Also added hwInitData.AddressTypeFlags. Added missing NTDDI definitions in vioscsi.h. Signed-off-by: benyamin-codez <[email protected]>
benyamin-codez
requested review from
vrozenfe and
YanVugenfirer
as code owners
|
Many thanks for the review, Yan...! Unfortunately I've run out of time for now... Best regards, |
Addendum to b6edb81. 1. Updated NTDDI descriptions and definitions to include Dilithium (25H1) and Selenium (25H2) development semesters 2. Corrected descriptions to only use development semesters rather than include some combinations with Windows versions 3. Updated definition comments to show development semesters Signed-off-by: benyamin-codez <[email protected]>
Addendum to b6edb81 and b7904fc. 1. Removed hwInitData.AddressTypeFlags per code review. Split to PR virtio-win#1225. Signed-off-by: benyamin-codez <[email protected]>
Addendum to b6edb81, b7904fc and acaf26d. 1. Split NTDDI_ definitions to new file ntddi_ver.h with minor refactor. 2. Minor refactor for RegistryPath reporting to appear outside of conditional. 3. Removed references to obsoleted RUN_MIN_CHECKED definition (PR virtio-win#1228). Signed-off-by: benyamin-codez <[email protected]>
Addendum to b6edb81, b7904fc, acaf26d and f47d4d0. 1. Fix typos in cases for Dilithium (25H1) and Selenium (25H2) dev semesters. Signed-off-by: benyamin-codez <[email protected]>
|
@YanVugenfirer @vrozenfe @kostyanf14 This one should be right to go again. I've fixed the problem breaking compilation (my bad), so the All appears to work as expected in both Win10 and Win11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the RegistryPath.
Show the CrashDump Mode.
Show
StorPortInitialize()return value (including LONG).Show
NTDDI_VERSION.Also added
hwInitData.AddressTypeFlags.Added missing
NTDDIdefinitions invioscsi.h.