-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI-NO-BUILD] [build] Scrub the cleaners #1211
base: master
Are you sure you want to change the base?
Conversation
a) Standardised cleaner routines b) Introduced -quiet and -debug parameters when run from repo root c) Moved from FOR loop to a shift loop to more reliably support a wider variety of directory formats and characters d) Created NetKVM/clean_inx.cmd to delete *.inx files in NetKVM e) Updated NetKVM/clean_dvl_log.cmd to use standardised routines f) Moved all other custom clean operations to build/clean.bat g) Added missing cleaner to viocrypt h) Added missing entries for viomem and viocrypt to list of directories to clean Signed-off-by: benyamin-codez <[email protected]>
Remove the following missing sub-directories from cleaning: a) viomem\app b) viorng\coinstaller Signed-off-by: benyamin-codez <[email protected]>
The following now just call
EDIT: Let me know if you want me to add a commit removing any of these superfluous cleaners. |
@benyamin-codez thanks for all the PRs! I am out in for the office until Wednesday. I will take a look after I am back. |
Added |
I think that we should keep them. As those directories have VS projects, they can be compiled standalone. |
Addendum to 52d23db and 3bc554e. 1. Added entry for *.dvl-win1*.xml 2. Added entry for *.legacy_dvl_result.txt Signed-off-by: benyamin-codez <[email protected]>
@benyamin-codez I suggest to switch |
Addendum to 52d23db, 3bc554e and 933b732. 1. Removed packaging folder from root\clean.bat per PR virtio-win#1209. Signed-off-by: benyamin-codez <[email protected]>
@YanVugenfirer @vrozenfe @ybendito I have removed the packaging folder from I have retained the discrete but generic cleaners for the sub-projects per Yan's advice above:
This one should be right to go now... 8^d |
Refactoring:
a) Standardised cleaner routines
b) Introduced
-quiet
and-debug
parameters when run from repo rootc) Moved from
FOR
loop to aSHIFT
loop to more reliably support a wider variety of directory formats and charactersd) Created
NetKVM\clean_inx.cmd
to delete*.inx
files inNetKVM
e) Updated
NetKVM\clean_dvl_log.cmd
to use standardised routinesf) Moved all other custom clean operations to
build\clean.bat
g) Added missing cleaner to
viocrypt
h) Added missing entries for
viomem
andviocrypt
to list of directories to cleanRemove the following missing sub-directories from cleaning:
a)
viomem\app
b)
viorng\coinstaller