Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[viostor] Backport vioscsi SendSRB fixes and improvements #1174

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[viostor] Backport vioscsi SendSRB fixes and improvements #1174

merged 1 commit into from
Nov 11, 2024

Conversation

benyamin-codez
Copy link
Contributor

Backports fixes and improvements from vioscsi PRs #1150 and #1162

virtqueue struct vq was also removed in favour of adaptExt->vq[QueueNumber], which results in a minor performance increase.

@benyamin-codez
[viostor] Backport vioscsi SendSRB fixes and improvements
140f273 
Backports fixes and improvements from vioscsi PRs virtio-win#1150 and virtio-win#1162

virtqueue struct vq was also removed in favour of adaptExt->vq[QueueNumber],
which results in a minor performance increase.

Signed-off-by: benyamin-codez <[email protected]>
@benyamin-codez benyamin-codez mentioned this pull request Oct 23, 2024
Closed
@benyamin-codez
Copy link
Contributor Author

This will likely fix issues #756 and #907.

@benyamin-codez benyamin-codez mentioned this pull request Oct 23, 2024
Closed
@benyamin-codez
Copy link
Contributor Author

@kostyanf14

I'm taking a punt that you're the person to ask the following. Please let me know if I should ask someone else.
Any idea why the checks are failing here and for #1175 also?
Looks like mostly file not found errors or what look to be environment-based unexpected reboots...
Is there a temporary problem with the test environment...?
Would appreciate your insight, especially if there are problems with my PRs...!
Best regards,
Ben

@kostyanf14
Copy link
Member

@benyamin-codez

We have an upstream bug for vioscsi. Viostor is unexpected behavior, we need to investigate the reason.

@benyamin-codez
Copy link
Contributor Author

@kostyanf14

From a quick look it appears to be the same issue, i.e. an unexpected 0x80070002 on a file copy...

@benyamin-codez benyamin-codez marked this pull request as ready for review October 25, 2024 06:00
@benyamin-codez benyamin-codez mentioned this pull request Nov 10, 2024
Merged
@benyamin-codez
Copy link
Contributor Author

@YanVugenfirer

If I'm not mistaken, this one should be good to go too, per #1181 (comment).
I note I have presumed (imho, fairly) that the resend logic wrapping the spinlocks in RhelDoFlush() is still valid.

Best regards,
Ben

cc: @vrozenfe, @kostyanf14

@YanVugenfirer YanVugenfirer merged commit 379f291 into virtio-win:master Nov 11, 2024
3 of 5 checks passed
@YanVugenfirer
Copy link
Collaborator

Thanks!

@robleady
Copy link

Can anyone advise if these fixes to viostor have made it into the binary downloads available from https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/ yet?
I can't see any mention in the changelogs there as to what's included.

@benyamin-codez
Copy link
Contributor Author

@robleady

I don't believe they are in v266. See my comment here.
Per Vadim's comment above that post, the next stable public build will be released in mid-end of January 2025.

@benyamin-codez benyamin-codez mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrozenfe vrozenfe vrozenfe approved these changes

@YanVugenfirer YanVugenfirer Awaiting requested review from YanVugenfirer YanVugenfirer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benyamin-codez @kostyanf14 @YanVugenfirer @robleady @vrozenfe