viogpu: Decouple DBG from WPP #1042
Conversation
| @@ -3411,6 +3411,8 @@ BOOLEAN VioGpuAdapter::CreateCursor(_In_ CONST DXGKARG_SETPOINTERSHAPE* pSetPoin | |||
| UINT resid, format, size; | |||
| VioGpuObj* obj; | |||
| PAGED_CODE(); | |||
| (void)pSetPointerShape; // unused | |||
There was a problem hiding this comment.
Sorry, why those two are added in this commit?
There was a problem hiding this comment.
Because those variables are not used. They are only referenced with DbgPrint but when you build non-debug build where it's no-op you'll get compiler warning so by this we silence that warning.
There was a problem hiding this comment.
The correct way to do it is to use UNREFERENCED_PARAMETER macro
UNREFERENCED_PARAMETER(pSetPointerShape);
UNREFERENCED_PARAMETER(pCurrentMode);
Like here:
|
@kostyanf14 Win2022x64 has two DF tests failing. Looks like something new, no? |
|
@YanVugenfirer Yes, two DF tests failing is a new one. I restarted the tests but it failed again in both PRs. Need to investigate the reason. Error occurs only in Win2022. |
Previously !DBG meant event tracing which can be confusing Signed-off-by: Dāvis Mosāns <[email protected]>
|
rerun tests |
| @@ -3411,6 +3411,8 @@ BOOLEAN VioGpuAdapter::CreateCursor(_In_ CONST DXGKARG_SETPOINTERSHAPE* pSetPoin | |||
| UINT resid, format, size; | |||
| VioGpuObj* obj; | |||
| PAGED_CODE(); | |||
| (void)pSetPointerShape; // unused | |||
There was a problem hiding this comment.
The correct way to do it is to use UNREFERENCED_PARAMETER macro
UNREFERENCED_PARAMETER(pSetPointerShape);
UNREFERENCED_PARAMETER(pCurrentMode);
Like here:
Previously
!DBGmeant event tracing which can be confusing.Now with this PR it's possible to build these combinations:
DBG 1- debug buildEVENT_TRACING 1- WPP build (default)