test: adjust os name variable in test cases #7877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yih-redhat
reviewed
Jun 14, 2024
ostree-ami-image.sh
Outdated
| ;; | ||
| *) | ||
| echo "unsupported distro: ${ID}-${VERSION_ID}" | ||
| exit 1;; | ||
| esac | ||
|
|
||
| if [[ "${ID}-${VERSION_ID}" == "rhel-9.5" ]]; then |
There was a problem hiding this comment.
Better to add a rhel 9.5 switch case and then set os_name like what you did in other cases.
There was a problem hiding this comment.
Done, thanks!
mcattamoredhat
force-pushed
the
adjust-os-name
branch
from
b01e7f7 to
c5f6aef
Compare
yih-redhat
previously approved these changes
Jun 17, 2024
ostree-ami-image.sh
Outdated
| OSTREE_REF="rhel/9/${ARCH}/edge" | ||
| SYSROOT_RO="true" | ||
| ANSIBLE_OS_NAME="rhel-edge" |
There was a problem hiding this comment.
on rhel9.3 and rhel9.4 , the os_name should be redhat?
There was a problem hiding this comment.
others looks good to me.
There was a problem hiding this comment.
Fixed, thanks!
mcattamoredhat
force-pushed
the
adjust-os-name
branch
from
c5f6aef to
4195c32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen in our downstream CI several failed tests due to inconsistency of os name (or ansible os name) variable across distros. Thus, playbook tasks such as find /var /mnt mount points failed.
This PR configures mentioned variable value to
rhel-edgeonly when test are perfomed by RHEL-9.5, centos-stream-9. In addition edge-commit will also haverhel-edgevariable value across all distros under test.