Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (rustc nightly-2023-07-15) #1430

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

vakaras
Copy link
Contributor

@vakaras vakaras commented Jul 20, 2023

No description provided.

@vakaras vakaras force-pushed the auto-update-nightly-2023-07-15 branch 4 times, most recently from d628217 to 2b47412 Compare July 21, 2023 13:02
@vakaras
Copy link
Contributor Author

vakaras commented Jul 21, 2023

@Aurel300 Your turn.

@Aurel300 Aurel300 self-assigned this Jul 21, 2023
@Aurel300 Aurel300 force-pushed the auto-update-nightly-2023-07-15 branch 3 times, most recently from 2667e3a to 727a0d9 Compare July 21, 2023 13:59
@vakaras vakaras force-pushed the auto-update-nightly-2023-07-15 branch from 1c840a4 to 4428054 Compare July 27, 2023 21:08
@vakaras
Copy link
Contributor Author

vakaras commented Aug 2, 2023

@Aurel300 What is the status of this?

@Aurel300 Aurel300 force-pushed the auto-update-nightly-2023-07-15 branch from 4428054 to 52e1d1d Compare August 2, 2023 23:36
@Aurel300
Copy link
Member

Aurel300 commented Aug 3, 2023

@vakaras Can you reproduce the error? Locally, when testing error_position.rs, I get the expected error locations, but on the CI they are one line off, it seems?

@fpoli
Copy link
Member

fpoli commented Aug 3, 2023

@vakaras Can you reproduce the error? Locally, when testing error_position.rs, I get the expected error locations, but on the CI they are one line off, it seems?

Did you re-download the viper_tools? Maybe it'd due to a change in Viper and you still have the old JARs.

@Aurel300
Copy link
Member

Aurel300 commented Aug 3, 2023

Ah, I actually did not, my bad!

@fpoli
Copy link
Member

fpoli commented Aug 3, 2023

It would actually be nice to make x.py auto-update the viper_tools when viper-toolchain changes... Adding a metadata file with the tag into all released Viper zip packages would be one way to do that.

@Aurel300 Aurel300 force-pushed the auto-update-nightly-2023-07-15 branch from 52e1d1d to b0d8893 Compare August 3, 2023 13:15
@vakaras
Copy link
Contributor Author

vakaras commented Aug 10, 2023

@Aurel300 What is the status of this?

@Aurel300
Copy link
Member

@vakaras I am still waiting for #1434: I see viper-sys is failing to build in the PR. Do you want me to take over that PR as well? Otherwise, this is either blocked or we don't upgrade the Viper version yet.

@vakaras
Copy link
Contributor Author

vakaras commented Aug 10, 2023

@vakaras I am still waiting for #1434: I see viper-sys is failing to build in the PR. Do you want me to take over that PR as well? Otherwise, this is either blocked or we don't upgrade the Viper version yet.

Marco is still working on it, so I would suggest not updating Viper.

@vakaras
Copy link
Contributor Author

vakaras commented Aug 10, 2023

It would actually be nice to make x.py auto-update the viper_tools when viper-toolchain changes... Adding a metadata file with the tag into all released Viper zip packages would be one way to do that.

You do not need to put the meta-data into the ZIP file. It should be sufficient to just change x.py setup to copy viper_toolchain to viper_tools folder after a successful update.

@Aurel300 Aurel300 force-pushed the auto-update-nightly-2023-07-15 branch from b0d8893 to fc61943 Compare August 11, 2023 08:14
@Aurel300 Aurel300 force-pushed the auto-update-nightly-2023-07-15 branch from fc61943 to 7e79b1d Compare August 11, 2023 09:14
@Aurel300 Aurel300 changed the title Update dependencies (rustc nightly-2023-07-15, viper v-2023-07-05-0730) Update dependencies (rustc nightly-2023-07-15) Aug 11, 2023
@Aurel300 Aurel300 merged commit d54e24d into master Aug 11, 2023
20 checks passed
@Aurel300 Aurel300 deleted the auto-update-nightly-2023-07-15 branch August 11, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants