Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #131

Merged
merged 9 commits into from
Dec 16, 2024
Merged

PHP 8.4 #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aba8e3f
PHP 8.4
eiriksm Jul 13, 2024
f0aed63
Update supportedPhpVersions.ts
eiriksm Jul 13, 2024
faf801a
Update createcloudjob.test.ts
eiriksm Jul 13, 2024
ed4dec6
Merge branch 'main' into eiriksm-patch-2
eiriksm Jul 13, 2024
5d12cf7
compiled
eiriksm Jul 13, 2024
f01741d
Merge branch 'main' into eiriksm-patch-2
eiriksm Sep 23, 2024
f72772f
Merge branch 'main' into eiriksm-patch-2
eiriksm Dec 15, 2024
f0e6cfd
Update createcloudjob.test.ts
eiriksm Dec 16, 2024
82c080b
Update createCloudJob.test.ts
eiriksm Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion built/supportedPhpVersions.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion built/supportedPhpVersions.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/supportedPhpVersions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ module.exports = [
'8.0',
'8.1',
'8.2',
'8.3'
'8.3',
'8.4'
]
3 changes: 2 additions & 1 deletion test/createcloudjob.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import fakeWatchClient from "./src/fakeWatchClient"
import promisify from "../src/promisify"
import * as fakePublisher from "./src/fakePublisher"
const supportedVersions = require("../src/supportedPhpVersions")
const composerVersions = [1, 2]
const composerVersions = [2]

describe('createCloudJob', () => {

Expand Down Expand Up @@ -76,6 +76,7 @@ describe('createCloudJob', () => {
'8.1': 'violinist-81-composer-',
'8.2': 'violinist-82-composer-',
'8.3': 'violinist-83-composer-',
'8.4': 'violinist-84-composer-',
}
for (const delta in supportedVersions) {
for (const cDelta in composerVersions) {
Expand Down
2 changes: 1 addition & 1 deletion test/integration/createCloudJob.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as should from 'should';
import * as AWS from 'aws-sdk'
import { createEcsTaskDefinition, createLogGroup } from "../../src/createCloudJob";
const composerVersions = [1, 2]
const composerVersions = [2]
const supportedVersions = require("../../src/supportedPhpVersions")


Expand Down
Loading