PHP 8.4 (#131)

* PHP 8.4 * Update supportedPhpVersions.ts * Update createcloudjob.test.ts * compiled * Update createcloudjob.test.ts * Update createCloudJob.test.ts
violinist-dev · Dec 16, 2024 · 51de798 · 51de798
1 parent bc6a4e9
commit 51de798
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/built/supportedPhpVersions.js b/built/supportedPhpVersions.js
diff --git a/built/supportedPhpVersions.js.map b/built/supportedPhpVersions.js.map
diff --git a/src/supportedPhpVersions.ts b/src/supportedPhpVersions.ts
@@ -7,5 +7,6 @@ module.exports = [
   '8.0',
   '8.1',
   '8.2',
-  '8.3'
+  '8.3',
+  '8.4'
 ]
diff --git a/test/createcloudjob.test.ts b/test/createcloudjob.test.ts
@@ -7,7 +7,7 @@ import fakeWatchClient from "./src/fakeWatchClient"
 import promisify from "../src/promisify"
 import * as fakePublisher from "./src/fakePublisher"
 const supportedVersions = require("../src/supportedPhpVersions")
-const composerVersions = [1, 2]
+const composerVersions = [2]
 
 describe('createCloudJob', () => {
 
@@ -76,6 +76,7 @@ describe('createCloudJob', () => {
             '8.1': 'violinist-81-composer-',
             '8.2': 'violinist-82-composer-',
             '8.3': 'violinist-83-composer-',
+            '8.4': 'violinist-84-composer-',
         }
         for (const delta in supportedVersions) {
             for (const cDelta in composerVersions) {

diff --git a/test/integration/createCloudJob.test.ts b/test/integration/createCloudJob.test.ts
@@ -1,7 +1,7 @@
 import * as should from 'should';
 import * as AWS from 'aws-sdk'
 import { createEcsTaskDefinition, createLogGroup } from "../../src/createCloudJob";
-const composerVersions = [1, 2]
+const composerVersions = [2]
 const supportedVersions = require("../../src/supportedPhpVersions")
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,5 +7,6 @@ module.exports = [ @@
       '8.0',
       '8.1',
       '8.2',
-      '8.3'
+      '8.3',
+      '8.4'
     ]