Fix support for decimal columns with null defaults

vimeo · Mar 12, 2021 · 6f177eb · 6f177eb
1 parent 144d67b
commit 6f177eb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Schema/Column/DecimalPointColumn.php b/src/Schema/Column/DecimalPointColumn.php
@@ -49,11 +49,21 @@ public function getPhpType() : string
 
     public function getPhpCode() : string
     {
+        $default = '';
+
+        if ($this->hasDefault()) {
+            $default = '->setDefault('
+                . ($this->getDefault() === null
+                    ? 'null'
+                    : '\'' . $this->getDefault() . '\'')
+                . ')';
+        }
+
         return '(new \\' . static::class . '('
             . $this->precision
             . ', ' . $this->scale
             . '))'
-            . ($this->hasDefault() ? '->setDefault(\'' . $this->getDefault() . '\')' : '')
+            . $default
             . $this->getNullablePhp();
     }
 }
diff --git a/tests/fixtures/create_table.sql b/tests/fixtures/create_table.sql
@@ -46,6 +46,7 @@ CREATE TABLE `transactions` (
 	`id` int(10) NOT NULL AUTO_INCREMENT,
 	`total` DECIMAL(12, 2) NOT NULL,
 	`tax` DECIMAL(12, 2) NOT NULL,
+	`other_tax` DECIMAL(12, 2) DEFAULT NULL,
 	PRIMARY KEY (`id`)
 )
 ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci;