Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating all dependencies, including omnipay/common to ^3.0 #104

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Updating all dependencies, including omnipay/common to ^3.0 #104

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5fd4b0f
Updating all dependencies, including omnipay/common to ^3.0
MelechMizrachi Jun 10, 2024
33ce199
Removing old guzzle/guzzle dependency.
MelechMizrachi Jun 10, 2024
9e782b9
Back to PHP 7.1.
MelechMizrachi Jun 10, 2024
0f288fe
Fix declaration of `setUp()` must be compatible with `Omnipay\Tests\T…
MelechMizrachi Jun 10, 2024
d769ad6
Update `http-interop/http-factory-guzzle` to ^1.1
MelechMizrachi Jun 10, 2024
4b9fbf3
Update AbstractRequest::validate to match signature of parent method.
MelechMizrachi Jun 10, 2024
b410171
Update dependencies.
MelechMizrachi Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,26 @@
}
},
"require": {
"vimeo/payment-gateway-logger": "^1.0",
"omnipay/common": "~2.0",
"php": "^7.4|^8.0",
"composer/ca-bundle": "^1.1",
"ext-soap": "*"
"ext-soap": "*",
"guzzle/common": "^3.9.2",
"guzzle/http": "^3.9.2",
"guzzle/parser": "^3.9.2",
"guzzle/plugin-mock": "^3.9.2",
"guzzle/stream": "^3.9.2",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to go, but for now they can stay. Gives us the ability to do "symfony/event-dispatcher": ">=2.1",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding this up is https://github.com/vimeo/omnipay-vindicia/blob/update-dependencies/src/Message/AbstractRequest.php#L138 taking in a Guzzle/Http/ClientInterface, instead of the new vindicia/common ClientInterface which also causes this to fail since the signature doesn't match: https://github.com/vimeo/omnipay-vindicia/blob/update-dependencies/src/Message/AbstractRequest.php#L140

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue with https://github.com/vimeo/omnipay-vindicia/blob/update-dependencies/src/Message/AbstractHOARequest.php#L28, but just on the __construct level, parent is AbstractRequest so there's no signature clash.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really we just need this to change: https://github.com/vimeo/omnipay-vindicia/blob/update-dependencies/src/Message/AbstractRequest.php#L145 along with taking an Omnipay\Common\Http\ClientInterface instead of a Guzzle\Http\ClientInterface and this should work out of the box.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/vimeo/omnipay-vindicia/blob/update-dependencies/tests/EventEmitterTest.php#L21 also needs to be updated

"omnipay/common": "^3.0",
"php-http/guzzle7-adapter": "^1.0.0",
"symfony/event-dispatcher": ">=2.1",
"vimeo/payment-gateway-logger": "^1.1.1"
},
"require-dev": {
"omnipay/tests": "~2.0"
"http-interop/http-factory-guzzle": "^1.2",
"omnipay/tests": "^4.0"
},
"config": {
"allow-plugins": {
"php-http/discovery": true
}
}
}
Loading