flag: support for integral slices #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiosalvatore
approved these changes
Jan 29, 2024
sources/flag/flaghelper/uints.go
Outdated
| return &UnsignedIntegralSliceFlag[I]{s: s} | ||
| } | ||
|
|
||
| // Set implement pflag.Value and flag.Value |
There was a problem hiding this comment.
nit: s/implement/implements/
sources/flag/flaghelper/ints.go
Outdated
| return &SignedIntegralSliceFlag[I]{s: s} | ||
| } | ||
|
|
||
| // Set implement pflag.Value and flag.Value |
There was a problem hiding this comment.
nit: s/implement/implements/
sources/flag/flaghelper/ints.go
Outdated
| "github.com/vimeo/dials/parse" | ||
| ) | ||
|
|
||
| // SignedInts represents all signed integer types |
There was a problem hiding this comment.
nit: s/SignedInts/SignedInt/
sources/flag/flaghelper/uints.go
Outdated
| "github.com/vimeo/dials/parse" | ||
| ) | ||
|
|
||
| // SignedInts represents all signed integer types |
There was a problem hiding this comment.
s/SignedInts/UnsignedInt/
There was a problem hiding this comment.
oh, right, golint gets unhappy with generics-related things.
Thanks!
(fixed)
sources/flag/flaghelper/uints.go
Outdated
| uint8 | uint16 | uint32 | uint64 | uint | uintptr | ||
| } | ||
|
|
||
| // SignedIntegralSliceFlag is a wrapper around an integral-typed slice |
There was a problem hiding this comment.
s/SignedIntegralSliceFlag/UnsignedIntegralSliceFlag/
sources/flag/flaghelper/uints.go
Outdated
| s *[]I | ||
| } | ||
|
|
||
| // NewStringSliceFlag is a constructor for StringSliceFlag |
There was a problem hiding this comment.
s/NewStringSliceFlag/NewUnsignedIntegralSlice/
silvenac
approved these changes
Jan 29, 2024
silvenac
reviewed
Jan 29, 2024
sources/flag/flag_test.go
Outdated
| @@ -78,6 +79,7 @@ func TestDefaultVals(t *testing.T) { | |||
| type otherUint16 uint16 | |||
| type otherUint32 uint32 | |||
| type otherUint64 uint64 | |||
| type otherUintptr uint64 | |||
There was a problem hiding this comment.
Indeed it is!
Fixed!
Also, add uintptr support. Extend the existing test cases to be comprehensive over the set of integer-types we support as well as integer slices.
dfinkel
force-pushed
the
flag_integral_type_slice_support
branch
from
852a1cf
to
ba90168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add uintptr support.
Extend the existing test cases to be comprehensive over the set of
integer-types we support as well as integer slices.