Multiple sinks #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v1 config is where we have a flat structure, this is backward compatible * v2 is new nested structure I have also added test cases for the changes I have brought in. Signed-off-by: Vigith Maurice <[email protected]>
…or testing * ability to pass context to controller that can be propagated * moving loading viper configs to a different method Signed-off-by: Vigith Maurice <[email protected]>
* support concurrency for UpdateEvents by using channels (fan-out) * multi sink approach * added new config format support and is backward compatible * add tests for sinks which i changed * ran go fmt Signed-off-by: Vigith Maurice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get to multiple sinks, following changes were made