Skip to content

Commit

Permalink
Remove redundant Typeable instances
Browse files Browse the repository at this point in the history
GHC now auto-derived `Typeable` instances since GHC 7.10, making the manually
derived `Typeable` instances in this library redundant. In GHC 9.12, `-Wall`
warns about these, so let's remove them.
  • Loading branch information
RyanGlScott committed Oct 29, 2024
1 parent 0aea260 commit 693eb03
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions src/Data/Functor/Contravariant/Day.hs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
{-# LANGUAGE Rank2Types #-}
{-# LANGUAGE MultiParamTypeClasses #-}
{-# LANGUAGE UndecidableInstances #-}
{-# LANGUAGE DeriveDataTypeable #-}
{-# LANGUAGE KindSignatures #-}
-----------------------------------------------------------------------------
-- |
Expand Down Expand Up @@ -39,11 +38,9 @@ import Data.Functor.Contravariant.Adjunction
import Data.Functor.Contravariant.Divisible
import Data.Proxy
import Data.Tuple (swap)
import Data.Typeable

-- | The Day convolution of two contravariant functors.
data Day f g a = forall b c. Day (f b) (g c) (a -> (b, c))
deriving Typeable

-- | Construct the Day convolution
--
Expand Down
3 changes: 0 additions & 3 deletions src/Data/Functor/Day.hs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE ExistentialQuantification #-}
{-# LANGUAGE KindSignatures #-}
{-# LANGUAGE DeriveDataTypeable #-}
{-# LANGUAGE RankNTypes #-}
{-# LANGUAGE MultiParamTypeClasses #-}
{-# LANGUAGE UndecidableInstances #-}
Expand Down Expand Up @@ -49,12 +48,10 @@ import Data.Profunctor.Composition (Procompose(..))
import Data.Functor.Adjunction
import Data.Functor.Identity
import Data.Functor.Rep
import Data.Typeable
import Prelude hiding (id,(.))

-- | The Day convolution of two covariant functors.
data Day f g a = forall b c. Day (f b) (g c) (b -> c -> a)
deriving Typeable

-- | Construct the Day convolution
day :: f (a -> b) -> g a -> Day f g b
Expand Down

0 comments on commit 693eb03

Please sign in to comment.