Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of lowpass subband dct approximation with new param --lowpass-dct #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mont3z
Copy link
Contributor

@mont3z mont3z commented Oct 13, 2017

Hi this implementation allows one to use lowpass dct approximation.
It reduces encoding time in approximately 10%.
A new parameter was added: lowpass-dct. It allows one to select lowpass subband dct approximation instead of the default dct implementation. Compression loss is minimal in qp > 27, specially for high resolution streams.

@XimingCheng
Copy link
Contributor

XimingCheng commented Oct 13, 2017

You changed the DCT procedure in x265. I want to know whether this change will get mismatch in encoder reconstruct picture and decoder output picture.
As normal DCT procedure is defined by HEVC standard and x265 must be compatible with standard HEVC spec.

Besides, you should sent your modification in a HG patch with an email to [email protected], you can ref more information at https://bitbucket.org/multicoreware/x265/wiki/Contribute.

@mont3z
Copy link
Contributor Author

mont3z commented Oct 13, 2017

Thx for your reply. I'll follow the procedures for a proper submission.
I did the performance tests using a x86 CPU with assembler enabled.

The encoded file is still 100% compatible with HEVC standards. The lowpass DCT gives results very similar to the standard DCT. However the DCT coefficient matrix is truncated by the lower order DCT size. So a 16x16 block after transformation will generate a 16x16 coeff but only values on the 8x8 uppper-left submatrix will be different than 0. This doesn't cause much problems in smooth blocks and if qp is large enough.

@mont3z
Copy link
Contributor Author

mont3z commented Oct 15, 2017 via email

@mont3z
Copy link
Contributor Author

mont3z commented Oct 15, 2017 via email

@XimingCheng
Copy link
Contributor

OK, now you can send your patch to [email protected], and MCW will test and review your patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants