Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallhaven #501

Closed
wants to merge 1 commit into from
Closed

Add wallhaven #501

wants to merge 1 commit into from

Conversation

trmdi
Copy link
Contributor

@trmdi trmdi commented Nov 24, 2024

This commit add wallhaven.cc
The user can input search keywords e.g. 'winter digital' or a full search url e.g. https://wallhaven.cc/search?categories=111&purity=110&topRange=1M&sorting=toplist&order=desc&ai_art_filter=1

Close #493
Depend on: #500

@trmdi
Copy link
Contributor Author

trmdi commented Nov 24, 2024

error 403 after downloading some images. This does not happen when downloading through a proxy like 0ms.dev/mirrors

I don't know why this happens. Could you explain ? Note that the image direct link is still accessible if you type it in the address bar.

Edit: This issue is fixed by removing the request referrer. Not sure if the server should also handle this case.

@trmdi trmdi force-pushed the add-wallhaven branch 3 times, most recently from 541f75f to 9cf6425 Compare November 24, 2024 15:03
@trmdi trmdi marked this pull request as ready for review November 24, 2024 15:26
@victrme
Copy link
Owner

victrme commented Nov 24, 2024

Hi @trmdi !

I'm not going to accept your PR because it is mostly a copy / paste of unsplash.ts, which is not at all the way we are going to do it... Also instead of force pushing, it would be preferable to have multiple commits, and the merge should be on dev and not master

@victrme victrme closed this Nov 24, 2024
@trmdi
Copy link
Contributor Author

trmdi commented Nov 24, 2024

I'm not going to accept your PR because it is mostly a copy / paste of unsplash.ts, which is not at all the way we are going to do it...

Oops, copy-paste is an issue? What way do you want to implement this?

@victrme
Copy link
Owner

victrme commented Nov 25, 2024

Don't worry about trying to implement this feature, we are going to integrate it with plenty of other features, so the code will be completely different.

I also need to improve the cache system, so this too will change.

I do appreciate all the effort you are doing to improve Bonjourr, so thank you for this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wallhaven.cc to the wallpaper provider
2 participants