Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws jenkins #2

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Aws jenkins #2

merged 4 commits into from
Oct 17, 2018

Conversation

greglarious
Copy link

adding artifactory variables

@greglarious greglarious self-assigned this Aug 9, 2018
@greglarious greglarious requested review from jsnrth and clemper August 9, 2018 20:23
@clemper
Copy link

clemper commented Aug 9, 2018

@greglarious This is a nit but could you fix the indentation to line up and use 2 space identation instead of 4 to be consistent with the rest of the file?

<layout>default</layout>
<id>central</id>
<name>artifactory_release</name>
<url>${env.ARTIFACTORY_LOCATION}artifactory/victorops_local</url>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need the slash, or no?

@jschwietert jschwietert merged commit 3504f2d into master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants