Fix extra lines generated when using clad::array or array_ref #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 94.87% 94.89% +0.01%
==========================================
Files 49 49
Lines 7478 7478
==========================================
+ Hits 7095 7096 +1
+ Misses 383 382 -1 |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Mar 4, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
parth-07
approved these changes
Mar 5, 2024
vgvassilev
reviewed
Mar 5, 2024
include/clad/Differentiator/Array.h
Outdated
| @@ -102,16 +109,16 @@ template <typename T> class array { | |||
| /// Returns the size of the underlying array | |||
| CUDA_HOST_DEVICE std::size_t size() const { return m_size; } | |||
| /// Returns the ptr of the underlying array | |||
| CUDA_HOST_DEVICE T* ptr() const { return m_arr; } | |||
| CUDA_HOST_DEVICE T*& ptr_ref() { return m_arr; } | |||
| CUDA_HOST_DEVICE T* ptr() const PUREFUNC { return m_arr; } | |||
There was a problem hiding this comment.
Suggested change
| CUDA_HOST_DEVICE T* ptr() const PUREFUNC { return m_arr; } | |
| CUDA_HOST_DEVICE PUREFUNC T* ptr() const { return m_arr; } |
Can we move the attributes to go first?
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #350