[cmake] Only require git when running benchmarks. #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should improve the current infrastructure for releasing clad on conda. The conda recipe downloads the tarball and it currently fails because we rely on being inside a git setup when building.
vgvassilev
force-pushed
the
fix-no-git
branch
from
af56562 to
f8b5a2e
Compare
alexander-penev
approved these changes
Feb 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 49 49
Lines 7342 7342
=======================================
Hits 6954 6954
Misses 388 388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the current infrastructure for releasing clad on conda. The conda recipe downloads the tarball and it currently fails because we rely on being inside a git setup when building.