Differentiate global variables in the reverse mode #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -286,6 +294,10 @@ class CladTimerGroup { | |||
| return P.ProcessDiffRequest(request); | |||
| } | |||
|
|
|||
| void ProcessTopLevelDecl(CladPlugin& P, clang::Decl* D) { | |||
There was a problem hiding this comment.
warning: function 'ProcessTopLevelDecl' defined in a header file; function definitions in header files can lead to ODR violations [misc-definitions-in-headers]
void ProcessTopLevelDecl(CladPlugin& P, clang::Decl* D) {
^Additional context
tools/ClangPlugin.h:296: make as 'inline'
void ProcessTopLevelDecl(CladPlugin& P, clang::Decl* D) {
^
PetroZarytskyi
force-pushed
the
globals
branch
from
cc0f843 to
de08917
Compare
PetroZarytskyi
force-pushed
the
globals
branch
from
de08917 to
7372dd0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
+ Coverage 94.56% 94.57% +0.01%
==========================================
Files 51 51
Lines 8944 8979 +35
==========================================
+ Hits 8458 8492 +34
- Misses 486 487 +1
... and 1 file with indirect coverage changes
|
vgvassilev
reviewed
Nov 25, 2024
| return StmtDiff(clonedDRE); | ||
| if (VD->isFileVarDecl() && | ||
| !m_DiffReq->hasAttr<clang::CUDAGlobalAttr>()) { | ||
| Expr* DREDiff = DifferentiateGlobalVarDecl(VD); |
There was a problem hiding this comment.
I think we can detect if a needed variable is global in the DiffPlanner and schedule it as part of the diff graph. This would enable us to remove the ProcessTopLevelDecl which is a layering violation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.