Add demo for comparison with libtorch (and pytorch) #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 93.80% 93.80%
=======================================
Files 55 55
Lines 8065 8065
=======================================
Hits 7565 7565
Misses 500 500 |
vgvassilev
reviewed
Jul 23, 2024
| @@ -0,0 +1,10 @@ | |||
| cmake_minimum_required(VERSION 3.18 FATAL_ERROR) | |||
There was a problem hiding this comment.
Can we add a bot to run this as part of the CI?
MihailMihov
reviewed
Jul 24, 2024
| } | ||
|
|
||
| // Benchmark the time for 100 matrix multiplications. | ||
| void benchmark_matrix_multiply(double x[M + N], double y[M]) { |
There was a problem hiding this comment.
I don't think it matters, but shouldn't x's size be [M * N] here?
There was a problem hiding this comment.
Also y seems to be unused here.
MihailMihov
reviewed
Jul 24, 2024
| std::mt19937 gen(42); | ||
|
|
||
| // Generate random input data and labels. | ||
| double x[M * N], y[M]; |
There was a problem hiding this comment.
Both of the demos seem to benchmark the multiplication XX, which I believe only makes sense if M=N. Maybe transpose one of them so that it's always valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.