-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support keystone-auth #297
Conversation
This has been tested on local lab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can take this as an opportunity to start cleaning up all of our manifests which are bundled. I think it's very difficult to manage them at the moment and I would like to suggest the following:
- Create a
charts
folder and start bundling the charts in there, if there is no chart, we build it (in this case for this) - Since we already have Helm on the system, we can simply use
helm template
with a custom values file instead of using Jinja2 - With that in place, we're able to simply just bump the chart data in here and easily change the overrides by relying on
values
instead of raw manifest files. - The templated value is what we "feed" into the ClusterResourceSet, and it also makes it easier for the long run to transition to the addon providers as well since we will have the charts ahead of time.
Can you make changes to this to accomodate for that?
273fd1f
to
01b3d08
Compare
what if i create a helm chart and deploy like cluster-autoscaler instead of rendering templates and feeding into ClusterResourceSet configmap? |
@okozachenko1203: this assumes that |
9bfe96d
to
7190e19
Compare
cfa6fcf
to
c42af81
Compare
fix #9