Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Validate fixed_network and fixed_subnet existence #139

Merged
merged 3 commits into from
Oct 31, 2023
Merged

feat: Validate fixed_network and fixed_subnet existence #139

merged 3 commits into from
Oct 31, 2023

Conversation

okozachenko1203
Copy link
Member

fix #118

@okozachenko1203 okozachenko1203 requested a review from mnaser June 30, 2023 13:29
mnaser
mnaser requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

"status": "CREATE_FAILED", "status_reason": "validate_cluster() missing 1 required positional argument: 'context'"

we should probably make the arguments context THEN cluster and add them to the call.

@okozachenko1203 okozachenko1203 force-pushed the validate-fixed-net-existence branch from 2aef807 to bd0d8c2 Compare July 3, 2023 09:12
@mnaser mnaser enabled auto-merge (rebase) July 4, 2023 13:17
@okozachenko1203 okozachenko1203 force-pushed the validate-fixed-net-existence branch 2 times, most recently from f76b4fb to 6c6b097 Compare July 7, 2023 12:41
@okozachenko1203 okozachenko1203 force-pushed the validate-fixed-net-existence branch from 6c6b097 to 0c13107 Compare July 14, 2023 13:51
@mnaser
Copy link
Member

mnaser commented Jul 20, 2023

@okozachenko1203 could you fix the merge conflicts for this please (i think one change we put context second, the other we put context first, i prefer that we have context first to be honest)

@okozachenko1203 okozachenko1203 force-pushed the validate-fixed-net-existence branch from 0c13107 to c8b37b7 Compare October 6, 2023 12:59
@okozachenko1203 okozachenko1203 force-pushed the validate-fixed-net-existence branch from bd60a73 to 2c7e9ee Compare October 20, 2023 09:42
@okozachenko1203 okozachenko1203 force-pushed the validate-fixed-net-existence branch from 2c7e9ee to cc11d3a Compare October 23, 2023 09:39
@mnaser mnaser merged commit 650480f into main Oct 31, 2023
30 checks passed
@mnaser mnaser deleted the validate-fixed-net-existence branch October 31, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser mnaser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail early if fixed_network or fixed_subnet don't exist
2 participants
@okozachenko1203 @mnaser