Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovn: Use chart name in oci_image_registry secret #1577

Merged

Conversation

gtirloni
Copy link
Contributor

The current values.yaml uses the service name to create separate secrets. However, helm-toolkit indexes into oci_image_registry using .Chart.Name and not $serviceName so the secrets are not used.

Upstream: https://review.opendev.org/c/openstack/openstack-helm-infra/+/923779

Pushing this as a patch until we have it upstream (applied with tox -e sync-charts).

The current values.yaml uses the service name to create separate
secrets. However, helm-toolkit indexes into oci_image_registry using
.Chart.Name and not $serviceName so the secrets are not used.

Upstream: https://review.opendev.org/c/openstack/openstack-helm-infra/+/923779
@mnaser
Copy link
Member

mnaser commented Jul 12, 2024

/cherry-pick stable/2024.1

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2024.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Member

mnaser commented Jul 12, 2024

/cherry-pick stable/2023.2

@mnaser
Copy link
Member

mnaser commented Jul 12, 2024

/cherry-pick stable/2023.1

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.2 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Member

mnaser commented Jul 12, 2024

/cherry-pick stable/zed

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/zed in a new PR and assign it to you.

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser mnaser added the gate label Jul 12, 2024
@atmosphere-ci atmosphere-ci bot merged commit 7df3df0 into vexxhost:main Jul 12, 2024
4 checks passed
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1583

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1585

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1587

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1589

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

atmosphere-ci bot pushed a commit that referenced this pull request Jul 13, 2024
This is an automated cherry-pick of #1577
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Jul 13, 2024
This is an automated cherry-pick of #1577
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Jul 13, 2024
This is an automated cherry-pick of #1577
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Jul 13, 2024
This is an automated cherry-pick of #1577
/assign mnaser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants