feat: Use vexxhost.containers #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricolin
force-pushed
the
move-to-vexxhost-containers
branch
2 times, most recently
from
270d161 to
b7ae771
Compare
mnaser
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Few other changes:
- Please delete the
directory,download_artifact,forget_package,packageandruncroles from here - Make sure you reference them from
vexxhost.containersinstead - There should be no code changes at all other than adding a
vexxhost.containersprefix :)
ricolin
force-pushed
the
move-to-vexxhost-containers
branch
from
b7ae771 to
3da1f56
Compare
mnaser
requested changes
Nov 22, 2023
molecule/forget-package/converge.yml
Outdated
| @@ -16,6 +16,6 @@ | |||
| hosts: all | |||
| become: true | |||
| roles: | |||
| - role: vexxhost.kubernetes.forget_package | |||
| - role: vexxhost.containers.forget_package | |||
There was a problem hiding this comment.
this molecule test should be moved to the collections repo
There was a problem hiding this comment.
by this i mean the entire molecule/forget-package folder should be moved to the containers collection, and then the tests should be there, and so we dont have to test it here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate to vexxhost/atmosphere#711