-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATMOSPHERE-461]Kube vip bgp + CI #147
Open
ricolin
wants to merge
19
commits into
vexxhost:main
Choose a base branch
from
ricolin:kube-vip-bgp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricolin
force-pushed
the
kube-vip-bgp
branch
13 times, most recently
from
December 10, 2024 12:55
26d35f1
to
a1feade
Compare
recheck |
mnaser
reviewed
Dec 11, 2024
mnaser
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round of changes and we can merge this one I guess.
recheck |
ricolin
force-pushed
the
kube-vip-bgp
branch
from
December 17, 2024 15:20
54f5bcd
to
2aa116b
Compare
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace * made changes per VexxHost Feedback * removed template * fixed variables
* template fix * space :|
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace * made changes per VexxHost Feedback * removed template * fixed variables * fixed template
whitespace
ricolin
force-pushed
the
kube-vip-bgp
branch
from
December 18, 2024 05:15
2aa116b
to
843063b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CI works + improvement and bug fixes for PR #140
Feat: Add BGP as an option for the Kube_VIP
AB#9103388