Split image versions from URLs to make overriding easier #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaser
requested changes
Nov 15, 2024
andrewbonney
force-pushed
the
split-versioned-vars
branch
from
35132c5 to
f37547c
Compare
andrewbonney
force-pushed
the
split-versioned-vars
branch
from
f37547c to
91c845f
Compare
|
@mnaser would you mind having another look at this and the containers patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the version out into a separate variable from image URLs. In doing so, when it is necessary to override image URLs to reference an offline registry, we can reference the image version(s) which match the version of this collection which we are pinning to.