Use include_tasks to respect group_vars #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaser
force-pushed
the
bugfix/respect_group_vars
branch
from
c9dcdd1 to
7ca2f52
Compare
With import_tasks all imports are processed very early, where some variables, like group_vars might not be yet processed. So if upload_helm_chart_method is defined in group_vars rather then extra vars, value will be ignored and role will proceed with it's defaults. Include in it's turn is more dynamic and will respect group_vars.
openstack-mirroring
pushed a commit
to openstack/openstack-ansible-ops
that referenced
this pull request
Nov 27, 2024
Makes sense to be consistent and follow suggestion to use group_vars where applicable. There is a bug in vexxhost collection which prevents from doing so, unfortunatelly. For this to be accurate doc, a patch to vexxhost collection should land first: vexxhost/ansible-collection-kubernetes#136 Change-Id: I5f48e913436bf5d6a8d6c0a9f77c58886e451d1f
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Nov 27, 2024
* Update openstack-ansible-ops from branch 'master'
to 23172d96b7491859f4a20e34daaf6b91e2efa2d1
- Merge "[doc] Move all variables to group_vars"
- [doc] Move all variables to group_vars
Makes sense to be consistent and follow suggestion to use group_vars
where applicable.
There is a bug in vexxhost collection which prevents from doing so,
unfortunatelly.
For this to be accurate doc, a patch to vexxhost collection should
land first:
vexxhost/ansible-collection-kubernetes#136
Change-Id: I5f48e913436bf5d6a8d6c0a9f77c58886e451d1f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With import_tasks all imports are processed very early, where some
variables, like group_vars might not be yet processed.
So if upload_helm_chart_method is defined in group_vars rather then
extra vars, value will be ignored and role will proceed with it's
defaults. Include in it's turn is more dynamic and will respect
group_vars.